Skip to content

Commit

Permalink
[CI]: Add python test on different python version (#219)
Browse files Browse the repository at this point in the history
* ci: add test on different python versions

* fix: use List replace list in type hint
  • Loading branch information
brosoul authored Sep 25, 2024
1 parent aa3ed95 commit 6293127
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
name: Lint
steps:
- name: Check out source repository
Expand Down
4 changes: 2 additions & 2 deletions python/aibrix/aibrix/envs.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

import os
from typing import Optional
from typing import List, Optional

ENV_VARS_TRUE_VALUES = {"1", "ON", "YES", "TRUE"}

Expand All @@ -24,7 +24,7 @@ def _is_true(value: Optional[str]) -> bool:
return value.upper() in ENV_VARS_TRUE_VALUES


def _parse_list_str(value: Optional[str], sep: str = ",") -> Optional[list[str]]:
def _parse_list_str(value: Optional[str], sep: str = ",") -> Optional[List[str]]:
if value is None:
return None
return [str(item).strip() for item in value.split(sep)]
Expand Down

0 comments on commit 6293127

Please sign in to comment.