Disable ENABLE_PROBES_INJECTION in correct way (#779)

fix env error caused by helm set command, use —set-string for env bool Signed-off-by: Jiaxin Shan <[email protected]>
vllm-project · Mar 3, 2025 · 31e3cf9 · 31e3cf9
1 parent 6105dae
commit 31e3cf9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/config/dependency/kuberay-operator/README.md b/config/dependency/kuberay-operator/README.md
@@ -3,7 +3,7 @@
 Commands to export manifest from helm package. After you got manifest, copy to this folder.
 
 ```shell
-helm template kuberay-operator kuberay/kuberay-operator --namespace aibrix-system --version 1.2.1 --include-crds --set env[0].name=ENABLE_PROBES_INJECTION --set env[0].value=\"false\" --set fullnameOverride=kuberay-operator --set featureGates[0].name=RayClusterStatusConditions --set featureGates[0].enabled=true --output-dir ./config/dependency
+helm template kuberay-operator kuberay/kuberay-operator --namespace aibrix-system --version 1.2.1 --include-crds --set env[0].name=ENABLE_PROBES_INJECTION --set-string env[0].value=false --set fullnameOverride=kuberay-operator --set featureGates[0].name=RayClusterStatusConditions --set featureGates[0].enabled=true --output-dir ./config/dependency
 ```
 
 If you use zsh, please use `noglob helm ...` to skip the brace check.
diff --git a/config/dependency/kuberay-operator/templates/deployment.yaml b/config/dependency/kuberay-operator/templates/deployment.yaml
@@ -51,7 +51,7 @@ spec:
               protocol: TCP
           env:
             - name: ENABLE_PROBES_INJECTION
-              value: '"false"'
+              value: "false"
           livenessProbe:
             httpGet:
               path: /metrics