Put in test for sampler #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sampler's CMakeLists.txt: add_library to kp_add_library
\n is faster for performance
Parallel scan sampling test based on example here: https://kokkos.org/kokkos-core-wiki/API/core/parallel-dispatch/parallel_scan.html
View index access of x does not use []
second argument
The typo was kokkospk_end_parallel_scan. This causes the third test for the sampler to fail.
Co-authored-by: Daniel Arndt <[email protected]>
Co-authored-by: Damien L-G <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CTest and GTest for testing of sampling utility. This is part of a general effort to test all tools of Kokkos Tools.