-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless v-fullscreenButtonDisplay class #156
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
726b628
to
a7d80c1
Compare
&.v-fullscreenButtonDisplay {
.v-controlBar,
.v-bigPlay {
position: fixed;
z-index: 8;
}
} Can you test if the this CSS can be removed? If not, what is the purpose? |
a7d80c1
to
81acb45
Compare
It no longer seems useful and it works without. Tested on Chrome, Firefox and Edge on fullscreen, the big play button is visible. @rtritto I've added a commit to your branch with the changes. If it's OK with you, I'll merge it. |
@yoriiis I added a commit. |
@rtritto I don't know whether the CSS class |
40d2e39
to
6693471
Compare
You're right.
Yes, it's better and clear. I did the commit. |
Available in release |
Thev-fullscreenButtonDisplay
component can use latestz-index
instead of2147483647
.Merge after #155 is merged.v-fullscreenButtonDisplay
class is useless, remove it.This PR contains a:
Motivation / Use-Case
Improvez-index
value logic and reduce size.