Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to customize the shortcuts value of volume and seek #152

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Feb 18, 2025

This PR contains a feature that fix:


  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Note

To be tested and reviewed

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vlite ✅ Ready (Inspect) Visit Preview Feb 18, 2025 9:14pm

@rtritto
Copy link
Contributor Author

rtritto commented Feb 18, 2025

FYI @yoriiis

@yoriiis
Copy link
Member

yoriiis commented Feb 18, 2025

Thank you @rtritto for your contribution, I've reviewed and requested a few changes.

@yoriiis
Copy link
Member

yoriiis commented Feb 18, 2025

FYI, about the lint job, with VSCode and the workspace mode, auto-save will fix indent for you

@rtritto
Copy link
Contributor Author

rtritto commented Feb 18, 2025

FYI, about the lint job, with VSCode and the workspace mode, auto-save will fix indent for you

That's the lint of Biome.
I did a commit to lint and do some change.

@yoriiis yoriiis merged commit abc679b into vlitejs:main Feb 20, 2025
13 checks passed
@rtritto rtritto deleted the custom-volume-seek-shortcut branch February 22, 2025 01:12
@yoriiis yoriiis mentioned this pull request Feb 23, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize seek value of shortcuts Customize volume value of shortcuts
2 participants