Skip to content

Conversation

@ymajoros
Copy link

@ymajoros ymajoros commented Nov 7, 2023

No description provided.

@ymajoros
Copy link
Author

ymajoros commented Nov 8, 2023

#675 actually solves it in a better way. They could still be split in 2, but I think it's not worth it, as further refactorings were needed.

@vladmihalcea
Copy link
Owner

@ymajoros Why make all these changes instead of just doing this instead?

String sql = SQLExtractor.from(criteriaQuery.unwrap(Query.class));

ymajoros pushed a commit to ymajoros/hypersistence-utils that referenced this pull request Nov 13, 2023
@ymajoros
Copy link
Author

@vladmihalcea this seems to indeed simplify it. I updated #675 with that, as it was needed there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants