Skip to content

feat(commands-guide): per-chip explanation modal for EK + MK#5

Open
thieung wants to merge 1 commit into
mainfrom
feat/commands-guide-chip-explanations
Open

feat(commands-guide): per-chip explanation modal for EK + MK#5
thieung wants to merge 1 commit into
mainfrom
feat/commands-guide-chip-explanations

Conversation

@thieung
Copy link
Copy Markdown
Contributor

@thieung thieung commented May 14, 2026

Summary

  • Click "Details" on any command card in /guides/commands opens a native <dialog> modal listing every subcommand / arg / flag / beta-flag with a 1-line explanation. Card height is unchanged so the grid does not jump.
  • Schema migration: Chip = string | ChipItem (dual-shape, backward compatible). All EK + MK chips now carry an i18n descKey.
  • Content: 118 EK + 121 MK chip explanations, fully bilingual (EN + VI). 478 i18n entries total. Sourced from upstream reference/{stable,marketing-stable}/.claude/skills/<name>/SKILL.md.
  • Modal: native <dialog> + showModal(), force-centered via position: fixed; inset: 0; margin: auto; to bypass Tailwind reset. Backdrop blur, scroll on overflow, Esc/click-outside close.

Test plan

  • npm run build → 61 pages green
  • /guides/commands (EN) — click "Details" on /ck:plan (8 flags + 3 subcommands) confirms modal centered, content rendered, scroll works
  • /guides/commands (EN) — click "Details" on /ckm:plan:* and /ckm:write:good confirms MK modal works
  • /vi/guides/commands — same checks with VI translations
  • Esc closes modal; click outside closes; X button closes
  • Card height does not change when modal opens (grid stays aligned)
  • Marketing Kit chips with legacy string fallback still render (those without descKey just show as chips, no modal row)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vividkit-web Ready Ready Preview, Comment May 14, 2026 6:53pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant