Skip to content

Upgrade the Golang Dependencies - #18082

Merged
deepthi merged 4 commits into
mainfrom
upgrade-go-deps-on-main
May 7, 2025
Merged

deepthi merged 4 commits into
mainfrom
upgrade-go-deps-on-main

Conversation

@vitess-bot

@vitess-bot vitess-bot commented Apr 1, 2025 •

Copy link
Copy Markdown
Contributor

This Pull Request updates all the Golang dependencies to their latest version using go get -u ./....
The exception is dd-trace-go.v1 which we pin to v1.69.1 because all versions after that have goroutine leaks that fail our unit tests.
cc @vitessio/release

@vitess-bot vitess-bot added Component: General Changes throughout the code base go Type: Dependencies Dependency updates labels Apr 1, 2025
@vitess-bot
vitess-bot requested a review from a team April 1, 2025 00:21
@vitess-bot

vitess-bot Bot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot Bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 1, 2025
@github-actions github-actions Bot added this to the v22.0.0 milestone Apr 1, 2025
@frouioui frouioui modified the milestones: v22.0.0, v23.0.0 Apr 1, 2025
@vitess-bot
vitess-bot force-pushed the upgrade-go-deps-on-main branch from 9d92d00 to 007dcc1 Compare April 15, 2025 00:20
Signed-off-by: GitHub <noreply@github.com>
@vitess-bot
vitess-bot force-pushed the upgrade-go-deps-on-main branch from 007dcc1 to cfc04b2 Compare May 1, 2025 00:23
@deepthi deepthi removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 6, 2025
@deepthi

deepthi commented May 6, 2025

Copy link
Copy Markdown
Contributor

h/t @frouioui for pointing me to #17803 (comment)

Signed-off-by: deepthi <deepthi@planetscale.com>
@codecov

codecov Bot commented May 6, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.49%. Comparing base (421aca0) to head (f87667a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18082      +/-   ##
==========================================
+ Coverage   67.47%   67.49%   +0.02%     
==========================================
  Files        1602     1602              
  Lines      262191   262191              
==========================================
+ Hits       176907   176969      +62     
+ Misses      85284    85222      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

deepthi added 2 commits May 6, 2025 14:46
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
deepthi requested a review from notfelineit as a code owner May 6, 2025 21:48
@deepthi
deepthi merged commit 516b854 into main May 7, 2025
@deepthi
deepthi deleted the upgrade-go-deps-on-main branch May 7, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base go Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants