Repository navigation
Upgrade the Golang Dependencies - #18082
Merged
Merged
Conversation
vitess-bot
requested review from
deepthi,
harshit-gangal,
mattlord and
rohit-nayak-ps
as code owners
April 1, 2025 00:21
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
force-pushed
the
upgrade-go-deps-on-main
branch
from
April 15, 2025 00:20
9d92d00 to
007dcc1
Compare
Signed-off-by: GitHub <noreply@github.com>
vitess-bot
force-pushed
the
upgrade-go-deps-on-main
branch
from
May 1, 2025 00:23
007dcc1 to
cfc04b2
Compare
Contributor
|
h/t @frouioui for pointing me to #17803 (comment) |
Signed-off-by: deepthi <deepthi@planetscale.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18082 +/- ##
==========================================
+ Coverage 67.47% 67.49% +0.02%
==========================================
Files 1602 1602
Lines 262191 262191
==========================================
+ Hits 176907 176969 +62
+ Misses 85284 85222 -62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
approved these changes
May 7, 2025
frouioui
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request updates all the Golang dependencies to their latest version using
go get -u ./....The exception is dd-trace-go.v1 which we pin to v1.69.1 because all versions after that have goroutine leaks that fail our unit tests.
cc @vitessio/release