Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Fix Data race in semi-join (#17417) #17445

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Dec 28, 2024

Description

This is a backport of #17417

@vitess-bot vitess-bot bot added Backport This is a backport Component: Query Serving Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Dec 28, 2024
Copy link
Contributor Author

vitess-bot bot commented Dec 28, 2024

Hello @GuptaManan100, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 17445 -R vitessio/vitess
git reset --hard origin/release-19.0
git cherry-pick -m 1 c25802da2ac3c49fe8c60d5107790813e1ef060c

Copy link
Contributor Author

vitess-bot bot commented Dec 28, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.9 milestone Dec 28, 2024
@GuptaManan100 GuptaManan100 removed Skip CI Skip CI actions from running Merge Conflict labels Dec 28, 2024
@GuptaManan100 GuptaManan100 marked this pull request as ready for review December 28, 2024 09:57
@GuptaManan100 GuptaManan100 force-pushed the backport-17417-to-release-19.0 branch from ac0953b to 1b3223e Compare December 28, 2024 09:57
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.16%. Comparing base (765a103) to head (5d3d995).
Report is 1 commits behind head on release-19.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17445      +/-   ##
================================================
+ Coverage         65.13%   65.16%   +0.02%     
================================================
  Files              1560     1560              
  Lines            238316   238318       +2     
================================================
+ Hits             155227   155297      +70     
+ Misses            83089    83021      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink force-pushed the backport-17417-to-release-19.0 branch from f594eb0 to f8477ab Compare December 30, 2024 14:16
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the backport-17417-to-release-19.0 branch from f8477ab to 5d3d995 Compare December 30, 2024 14:30
@dbussink dbussink merged commit b3835b8 into release-19.0 Dec 30, 2024
201 checks passed
@dbussink dbussink deleted the backport-17417-to-release-19.0 branch December 30, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants