-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Direct PR] [V21 backport] CobraDocs: Remove commit hash from docs. Fix issue with workdir replacement (#17392) #17444
Merged
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nayak-ps
added
Type: Documentation
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
labels
Dec 27, 2024
rohit-nayak-ps
requested review from
ajm188,
deepthi and
mattlord
as code owners
December 27, 2024 18:25
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 27, 2024
rohit-nayak-ps
added
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 27, 2024
rohit-nayak-ps
added
Component: Documentation
docs related issues/PRs
and removed
Type: Documentation
labels
Dec 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-21.0 #17444 +/- ##
=============================================
Coverage 67.51% 67.52%
=============================================
Files 1570 1570
Lines 251429 251437 +8
=============================================
+ Hits 169764 169774 +10
+ Misses 81665 81663 -2 ☔ View full report in Codecov by Sentry. |
…cement (vitessio#17392) Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
force-pushed
the
v21-docgen
branch
from
December 28, 2024 12:52
ffa4f37
to
5f96176
Compare
dbussink
approved these changes
Dec 30, 2024
GuptaManan100
approved these changes
Dec 30, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
…ix issue with workdir replacement (#17392) (#17444) Signed-off-by: Rohit Nayak <[email protected]>
dbussink
pushed a commit
that referenced
this pull request
Dec 30, 2024
…ix issue with workdir replacement (#17392) (#17444) Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
pushed a commit
that referenced
this pull request
Dec 30, 2024
…sh from docs. Fix issue with workdir replacement (#17392) (#17444) (#17451) Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
rohit-nayak-ps
added a commit
that referenced
this pull request
Dec 30, 2024
…sh from docs. Fix issue with workdir replacement (#17392) (#17444) (#17450) Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Rohit Nayak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Component: Documentation
docs related issues/PRs
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #17392
We need to backport the original PR because we checkout previous releases while generating docs for previous versions and hence the older versions also need the fixes from #17392.
Hoping to piggyback backport these to v19/v20 as well using labels and not have to create manual backports.
Related Issue(s)
#17392
Checklist
Deployment Notes