-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LookupVindex: Implement internalize
command for lookup vindexes
#17429
Open
beingnoble03
wants to merge
4
commits into
vitessio:main
Choose a base branch
from
beingnoble03:lookup-vindex-internalize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LookupVindex: Implement internalize
command for lookup vindexes
#17429
beingnoble03
wants to merge
4
commits into
vitessio:main
from
beingnoble03:lookup-vindex-internalize
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noble Mittal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 24, 2024
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Signed-off-by: Noble Mittal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17429 +/- ##
==========================================
- Coverage 67.67% 67.63% -0.04%
==========================================
Files 1583 1584 +1
Lines 254363 254624 +261
==========================================
+ Hits 172140 172216 +76
- Misses 82223 82408 +185 ☔ View full report in Codecov by Sentry. |
beingnoble03
added
Type: Feature
Component: VReplication
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Dec 30, 2024
beingnoble03
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188,
notfelineit,
rohit-nayak-ps,
GuptaManan100 and
shlomi-noach
as code owners
December 30, 2024 06:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
internalize
andcomplete
command for lookup vindexesexternalize
command where we stop the workflow and mark it as frozen instead of deleting it.complete
command checks if the lookup vindex is externalized, and if it has an owner, it deletes the workflow.internalize
command starts the frozen streams (if there's an owner) and sets thewrite_only
vindex param back totrue
(which was deleted when lookup vindex was externalized.)Related Issue(s)
LookupVindex
has nointernalize
command (equivalent toReverseTraffic
) #15985Checklist
Deployment Notes