Fix: UI improvements in navbar, status, compare page. #548
Conversation
|
hey @frouioui ! Can you share your views on this pls and guide me further. (I'm quite new to open source) |
There was a problem hiding this comment.
Hey @whatDeepak, can you check out the file comments? Thanks!
| <div className="flex flex-col md:flex-row gap-4 overflow-hidden"> | ||
| <ComparisonInput | ||
| name="old" | ||
| className="rounded-l-full" | ||
| className="text-xl px-6 py-4 bg-background border-2 border-gray-300 rounded-full focus:border-primary focus:outline-none" | ||
| setGitRef={setGitRef} | ||
| gitRef={gitRef} | ||
| /> | ||
| <ComparisonInput | ||
| name="new" | ||
| className="rounded-r-full " | ||
| className="text-xl px-6 py-4 bg-background border-2 border-gray-300 rounded-full focus:border-primary focus:outline-none" |
There was a problem hiding this comment.
In my opinion we should keep the same style for the input as what we have on other pages, here is a diff between search and compare:
There was a problem hiding this comment.
got it, I'll make the input style consistent across pages
what i suggest: instead of keeping separate input boxes, i'll follow the old style only and make that responsive by decreasing the size of that in small devices
There was a problem hiding this comment.
hey @frouioui , kindly check if this is fine by you and addresses the review comments correctly?
this fix brings responsiveness to compare page while keeping the input style consistent with older design.
Before :
After :
Signed-off-by: Deepak <[email protected]>
Signed-off-by: Deepak <[email protected]>
|
Hello again @whatDeepak, truly thank you for taking the time to work on this. @Jad31 recently revamped these pages/components, I will then close this PR for now. |
This PR enhances the responsiveness and user experience of the application.
Issue Number:
Screenshots/videos:
Before:
After:
I believe these changes will significantly enhance the overall usability and accessibility of the application, contributing to a more positive user experience.
Additionally, I'd like to request access to secret key necessary to further contribute to the project. Having access to these resources will enable me to continue making meaningful contributions to the project's development.
I'm looking forward to your feedback and suggestions for further improvements. :)