Skip to content

feat: show dependency optimization progress in CLI #21167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hlongc wants to merge 4 commits into
base: main
Choose a base branch
from
+23 −2
Open

feat: show dependency optimization progress in CLI #21167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fde556d
feat: show dependency optimization progress in CLI
hlongc Nov 28, 2025
18e0340
chore: fix code formatting
hlongc Nov 28, 2025
b33dcc9
fix: prevent precision loss in duration conversion
hlongc Nov 29, 2025
d97d179
Merge upstream/main and resolve conflicts
hlongc Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/vite/src/node/optimizer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,15 @@ export function runOptimizeDeps(

const start = performance.now()

// Show progress for non-debug mode
const depCount = qualifiedIds.length
environment.logger.info(
colors.green(
`Pre-bundling ${depCount} ${depCount === 1 ? 'dependency' : 'dependencies'}...`,
),
{ timestamp: true },
)

const preparedRun = prepareEsbuildOptimizerRun(
environment,
depsInfo,
Expand Down Expand Up @@ -717,8 +726,12 @@ export function runOptimizeDeps(
}
}

debug?.(
`Dependencies bundled in ${(performance.now() - start).toFixed(2)}ms`,
const durationMs = (performance.now() - start).toFixed(2)
const durationS = (parseInt(durationMs) / 1000).toFixed(2)
Copy link
Contributor

@graphite-app graphite-app bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic error in time conversion causes precision loss. durationMs is already a string from .toFixed(2), and parseInt(durationMs) truncates the decimal part before converting to seconds.

For example, if the actual time is 1234.99ms:

  • Current code: parseInt("1234.99") = 1234, then 1234/1000 = 1.234s
  • Correct: 1234.99/1000 = 1.23499s

This loses up to 0.99ms of precision in the seconds display. Fix by storing the numeric value first:

const duration = performance.now() - start
const durationMs = duration.toFixed(2)
const durationS = (duration / 1000).toFixed(2)
Suggested change
const durationMs = (performance.now() - start).toFixed(2)
const durationS = (parseInt(durationMs) / 1000).toFixed(2)
const duration = performance.now() - start
const durationMs = duration.toFixed(2)
const durationS = (duration / 1000).toFixed(2)

Spotted by Graphite Agent

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Author

@hlongc hlongc Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed the precision loss issue by storing the numeric duration first. Thanks for the detailed explanation! 👍

debug?.(`Dependencies bundled in ${durationMs}ms`)
environment.logger.info(
colors.green(`✨ Dependencies optimized in ${durationS}s`),
{ timestamp: true },
)

return successfulResult
Expand Down
4 changes: 4 additions & 0 deletions packages/vite/src/node/optimizer/optimizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@ export function createDepsOptimizer(
;(async () => {
try {
debug?.(colors.green(`scanning for dependencies...`))
logger.info(
colors.green(`Scanning dependencies...`),
{ timestamp: true },
)

let deps: Record<string, string>
try {
Expand Down
Loading