fix(dev): trigger prune event when last import is removed (#20781) #21093
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
reviewed
Dec 1, 2025
| !imports.length && | ||
| !(this as unknown as TransformPluginContext)._addedImports | ||
| ) { | ||
| importerModule.isSelfAccepting = false |
Member
There was a problem hiding this comment.
I guess we need to keep this line. What was the reason to remove this line?
Member
There was a problem hiding this comment.
Would you add a separate test for the previous one so that we have a test that covers the non-early-return path?
sapphi-red
added
feat: hmr
p2-edge-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger prune event when the last import of a module is removed.
Fixes #20781
Since
imports.lengthis0, there are no imported, accepted, or statically imported modules. Therefore,moduleGraph.updateModuleInfois called with empty sets to get theprunedImportsand trigger the event.