Skip to content

feat: support RegExp | RegExp[] for external #20933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: support RegExp | RegExp[] for external #20933

wants to merge 5 commits into from
+266 −58

Conversation

elecmonkey
Copy link

Description

Changes

  • Extended resolve.external type from string[] | true to string | RegExp | (string | RegExp)[] | true.
  • Try to ensure that existing inputs are not affected in any way

Documentation

  • Updated docs/config/ssr-options.md

Issues

Fixes #20843

hi-ogawa
hi-ogawa reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test cases?

@elecmonkey
Copy link
Author

Can you add test cases?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hi-ogawa hi-ogawa hi-ogawa left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RegExp | RegExp[] for external not supported

2 participants

@elecmonkey @hi-ogawa