Skip to content

Conversation

sapphi-red
Copy link
Member

Description

dev.createEnvironment was called one-by-one for each environment, but I think we can call these concurrently.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Aug 29, 2025
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

Copy link

pkg-pr-new bot commented Aug 29, 2025

Open in StackBlitz

npm i https://pkg.pr.new/vite@20699

commit: 9723372

@vite-ecosystem-ci
Copy link

hi-ogawa
hi-ogawa previously approved these changes Aug 30, 2025
@bluwy
Copy link
Member

bluwy commented Sep 7, 2025

It looks like in build these are also called sequentially. If we decide to call in concurrently now, I think we should do the same for dev and build for consistency.

From a brief look at the build code, it seems tricky to do in parallel though.

@sapphi-red sapphi-red changed the title perf: run dev.createEnvironment concurrently perf: run dev.createEnvironment and build.createEnvironment concurrently Sep 16, 2025
@sapphi-red
Copy link
Member Author

Good catch! I've updated build.createEnvironment to run concurrently. I left the config loading as sequential to be safe.

@sapphi-red sapphi-red added this to the 7.2 milestone Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority) trigger: preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants