chore: clarify HTTP/2 server compatibility with Connect app #20664
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves the TODO comment in resolveHttpServer by replacing @ts-expect-error with a proper type cast and explanatory comment. When allowHTTP1: true is set, the HTTP/2 server can handle HTTP/1.1 requests, making the Connect app compatible as a request listener since: - Http2ServerRequest extends IncomingMessage - Http2ServerResponse extends ServerResponse - The server operates in HTTP/1.1 compatibility mode This change improves code clarity and maintainability by removing the ambiguous TODO and explaining the type compatibility.
Where is this written / ensured? The type definition or the actual implementation does not extend them. |
sapphi-red
changed the title
sapphi-red
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the TODO comment in resolveHttpServer by replacing @ts-expect-error with a proper type cast and explanatory comment.
When allowHTTP1: true is set, the HTTP/2 server can handle HTTP/1.1 requests, making the Connect app compatible as a request listener since:
This change improves code clarity and maintainability by removing the ambiguous TODO and explaining the type compatibility.
Description