-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs: fix some mistakes in Environment API guides #20000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Wow, I sure did suck at this 😆 Thanks for being so constructive about it, though, and let me know if there's anything else. |
Oh, no problem! It is good to see where you are finding difficulties in the docs. I'll let others check the PR to see if they would like to change the environment names as you proposed. To be honest, I'm fine with the names we had (except for the typo you corrected with |
Description
I love the Environment API. Here are a few important fixes to the guides to help people when trying it out:
node
environment toserver
remove the usage of the non-existentvite-environment-provider
packageenvironment
), and specific in others (ssrEnvironment
), so I made them all specific, which I believe is good practice anywaythere is advice thatssr
environment can be calledserver
as well, which is arguably misleading because creating aserver
environment would not receive any of the built-inssr
configuration, so I simply removed this sentence