refactor!: remove HotBroadcaster
#19988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
built on top of #19987This PR removes
HotBroadcaster
type and changes the type ofserver.hot
toNormalizedHotChannel
.server.hot
is more like an alias toserver.environments.client.hot
instead of a separate conceptHotBroadcaster.addChannel
methodHotBroadcaster.channels
property.HotBroadcaster
is deprecated butserver.hot
is not deprecated, maybe users won't expect this property to be removed.HotBroadcaster.channels
property. If removing this property directly without a deprecation phase, this commit can be included. I guess it's fine to remove it directly. It's always[server.ws]
and easy to replace. While I foundserver.hot
used in many places, I only foundhot.channels
used in a single place.I didn't deprecate
server.hot
as it's used in many places and keeping that won't be much burden.