fix: examples wlr-randr scale not work #470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zccrs
requested changes
Aug 22, 2024
|
WOutputManagerV1 has move to cpp impl, why qml not delete this? |
drm is pending, commit will fail, set scale to become invalid. do not commit and wait until the next frame to complete the scaling settings. Signed-off-by: pengwenhao <[email protected]>
done |
wineee
reviewed
Sep 19, 2024
| @@ -264,8 +264,6 @@ void Helper::initProtocols(WOutputRenderWindow *window, QQmlEngine *qmlEngine) | |||
|
|
|||
| if (onlyTest) | |||
| ok &= output->test(); | |||
| else | |||
| ok &= output->commit(); | |||
| } | |||
| m_wOutputManager->sendResult(config, ok); | |||
There was a problem hiding this comment.
Maybe we should send result in next commit
zccrs
requested changes
Sep 19, 2024
| @@ -264,8 +264,6 @@ void Helper::initProtocols(WOutputRenderWindow *window, QQmlEngine *qmlEngine) | |||
|
|
|||
| if (onlyTest) | |||
| ok &= output->test(); | |||
| else | |||
| ok &= output->commit(); | |||
| } | |||
| m_wOutputManager->sendResult(config, ok); | |||
|
Should not work without #508 ？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drm is pending, commit will fail, set scale to become invalid. do not commit and wait until the next frame to complete the scaling settings.