Skip to content

fix: include loaded paths in viewBox - #219

Open
w3lld1 wants to merge 1 commit into
vinothpandian:mainfrom
w3lld1:fix/viewbox-loaded-paths
Open

w3lld1 wants to merge 1 commit into
vinothpandian:mainfrom
w3lld1:fix/viewbox-loaded-paths

Conversation

@w3lld1

@w3lld1 w3lld1 commented Jul 13, 2026

Copy link
Copy Markdown

Summary

  • expand the withViewBox bounds to include loaded path coordinates
  • account for stroke radius so off-canvas stroke edges remain visible
  • add unit and browser coverage for paths extending beyond the rendered canvas

Validation

  • pnpm lint
  • pnpm test:unit (89 tests)
  • pnpm --filter react-sketch-canvas exec playwright test -c playwright-ct.config.ts --workers=1 (144 tests across Chromium and Firefox)
  • pnpm --filter react-sketch-canvas build
  • E2E: 14/16 passed; the existing 500-stroke × 500-point stress case exceeded its 10-second timeout in Chromium and Firefox on both this branch and an unchanged main worktree in this runner

Fixes #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withViewBox should fit loaded paths, not just rendered canvas size (follow-up to #114)

1 participant