update the "CallMap" #1186
Closed
update the "CallMap" #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> merge with https://github.com/phpstan/phpstan/pull/1759/files --- Maybe a new repository with a php "CallMap" is a good idea, so that other projects can also use it? And maybe some kind of generator (e.g.: https://github.com/thecodingmachine/safe/tree/master/generator) can also help to automatically apply those fixes?
weirdan
requested changes
Jan 9, 2019
| 'SQLiteDatabase::lastError' => ['int'], | ||
| 'SQLiteDatabase::lastInsertRowid' => ['int'], | ||
| 'SQLiteDatabase::query' => ['SQLiteResult', 'query'=>'string', 'result_type='=>'int', 'error_msg='=>'string'], | ||
| 'SQLiteDatabase::arrayQuery' => ['array', 'dbhandle'=>'', 'query'=>'string', 'result_type='=>'int', 'decode_binary='=>'bool'], |
There was a problem hiding this comment.
arrayQuery as a method does not accept dbhandle (at least according to PHP documentation). That's probably true for other methods here as well.
There was a problem hiding this comment.
Yeah, I'm going through and fixing that now, one sec
|
Thanks - I applied this myself in dc2f492 and 5b2d796 Added upstream in phan/PHPSignatures#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> merge with https://github.com/phpstan/phpstan/pull/1759/files
Maybe a new repository with a php "CallMap" is a good idea, so that other projects can also use it?
And maybe some kind of generator (e.g.: https://github.com/thecodingmachine/safe/tree/master/generator) can also help to automatically apply those fixes?