Skip to content

Conversation

@kkmuffme
Copy link
Contributor

@kkmuffme kkmuffme commented Oct 23, 2024

Start to make curl param and return types more specific.

Things that still need improving:

  • curl_getinfo
  • curl_setopt
  • param types where many are listed can potentially be more restricted when one goes through the actual constant values and their meaning. I just used the widest set possible according to the docs now.

Note: for the return type https://curl.se/libcurl/c/libcurl-errors.html needs to be used, bc the PHP docs https://www.php.net/manual/en/curl.constants.php are missing various values (the non-listed values can be returned, but not used as param, that's maybe why some of them are missing in the docs, but not sure)

@kkmuffme kkmuffme force-pushed the start-making-curl-types-more-specific branch from c6bc1e6 to 91f22d0 Compare October 23, 2024 20:10
@kkmuffme kkmuffme force-pushed the start-making-curl-types-more-specific branch from 91f22d0 to 79a587b Compare October 23, 2024 20:15
@kkmuffme kkmuffme marked this pull request as ready for review October 23, 2024 20:22
@orklah
Copy link
Collaborator

orklah commented Feb 16, 2025

Can you rebase on 6.x?

@kkmuffme kkmuffme changed the base branch from 5.x to 6.x January 8, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants