Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when minipbrt::Loader::load(filename) could not open the file provided #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Uedaki
Copy link
Contributor

@Uedaki Uedaki commented Dec 29, 2023

When failing to open a file (minipbrt.cpp:4676), minipbrt would call set_error() prior to the creation m_filedata allocated few lines after. This would create a crash when set_error() is trying to access the pointer to retrieve the filename and the error offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant