Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(container): adjust wrong padding value in container fluid #43

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix(container): adjust wrong padding value in container fluid #43

merged 1 commit into from
Apr 24, 2024

Conversation

vandangnhathung
Copy link
Contributor

@vandangnhathung vandangnhathung commented Apr 24, 2024 •
edited
Loading

Problems

The current value is not responsive.

Solution

Replace with --bcnb-gap-container.

Before

.container-fluid {
    --bcnb-gap-side:56px;
}

After

.container-fluid {
    --bb-gap-side:var(--bcnb-gap-container);
}

@vandangnhathung vandangnhathung requested a review from phucbm April 24, 2024 07:45
@vandangnhathung vandangnhathung self-assigned this Apr 24, 2024
@phucbm
Copy link
Member

phucbm commented Apr 24, 2024

LGTM.

@phucbm phucbm merged commit a12a863 into v1.2.3 Apr 24, 2024
@phucbm phucbm deleted the fix-wrong-padding-container-fluid branch April 24, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phucbm phucbm phucbm approved these changes

Assignees

@vandangnhathung vandangnhathung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandangnhathung @phucbm