Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container size #33

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Add container size #33

merged 8 commits into from
Nov 27, 2023

Conversation

vandangnhathung
Copy link
Contributor

Build more options for container variables

@vandangnhathung vandangnhathung self-assigned this Nov 10, 2023
phucbm
phucbm requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@phucbm phucbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments. Also, make sure that when we remove the $container from the _config.scss, no errors throwed.

phucbm
phucbm requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@phucbm phucbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You really need to check the Files changed tab before asking for review.

@phucbm phucbm merged commit 3afc9b6 into staging Nov 27, 2023
@phucbm phucbm deleted the main-add-container-size branch November 27, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phucbm phucbm phucbm approved these changes

Assignees

@vandangnhathung vandangnhathung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandangnhathung @phucbm