Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(skeleton-bg): change animation #22

Merged
merged 2 commits into from
May 15, 2023
Merged

fix(skeleton-bg): change animation #22

merged 2 commits into from
May 15, 2023

Conversation

vuquangpham
Copy link
Contributor

@vuquangpham vuquangpham commented May 10, 2023 •
edited
Loading

Problem

Change the animation of the skeleton background

Current style:

current-style

New style:

ezgif-1-205e7e3b38

SVG Code

loading

@vuquangpham vuquangpham added the bug Something isn't working label May 10, 2023
@vuquangpham vuquangpham requested a review from phucbm May 10, 2023 11:31
@vuquangpham vuquangpham self-assigned this May 10, 2023
@vuquangpham vuquangpham changed the title fix(skeleton-bg): add background size fix(skeleton-bg): change animation May 15, 2023
@vuquangpham vuquangpham added enhancement New feature or request and removed bug Something isn't working labels May 15, 2023
phucbm
phucbm approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@phucbm phucbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phucbm phucbm merged commit 3f5b975 into 1.1.9 May 15, 2023
@phucbm phucbm deleted the skeleton-bg branch May 15, 2023 10:22
@vuquangpham vuquangpham mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phucbm phucbm phucbm approved these changes

Assignees

@vuquangpham vuquangpham

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuquangpham @phucbm