docs(types): document Player.error(null) for clearing MediaError#9174
Open
CyberVy wants to merge 1 commit intovideojs:mainfrom
Open
docs(types): document Player.error(null) for clearing MediaError#9174CyberVy wants to merge 1 commit intovideojs:mainfrom
CyberVy wants to merge 1 commit intovideojs:mainfrom
Conversation
Updated documentation for MediaError handling to clarify parameters.
Author
|
Could someone please review this PR, it'a just a simple fix. Thank you. |
gkatsev
approved these changes
Apr 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9174 +/- ##
=======================================
Coverage 84.32% 84.32%
=======================================
Files 120 120
Lines 8153 8153
Branches 1964 1964
=======================================
Hits 6875 6875
Misses 1278 1278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mister-ben
approved these changes
Apr 27, 2026
Dpuga13
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated documentation for MediaError handling to clarify parameters.
Description
player.errorsupportsnullas an input to clear the currentMediaError, however, this is not revealed in the docs which can impact type build.