Replace "collections/deque" with "queue" #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "collections" package has issues with array shims causing other dependencies to break when least expected. This has been discussed in multiple issues: - montagejs/collections#162 - montagejs/collections#95 - balderdashy/sails#2524 Another solution to this could be to depend on "[email protected]" instead which is a version without shims.
|
Hey @Bazze I totally appreciate this fix but I had actually already noticed and started on a solution to this problem. Yesterday, I went through and replaced all references in lib/connection.js to collections/deque to use the Immutable.js List. I was going to finish by doing the same in client.js today. I'd rather keep things consistent so I'd like to use the same library in both places and not use Thanks again for the work and I'm sorry again that I won't merge this. |
|
Great, sounds like an even better solution! |
|
Btw, when do you think you'll push a new version to npm that includes the change? :) |
|
Yup, pushed just now to npm as 0.2.13! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "collections" package has issues with array shims causing other dependencies to break when least expected. This has been discussed in multiple issues:
Another solution to this could also be to depend on "[email protected]" instead, which is a version without shims.
All tests pass with this change, so assuming they cover the queue part this change should be fine.