Fix camel case errors due to changes in team-monitor-website #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
avikalpg
approved these changes
Sep 12, 2023
Member
avikalpg
left a comment
avikalpg
left a comment
There was a problem hiding this comment.
This looks to me. But I just want to re-iterate that if making these camelCase starts throwing errors or warnings, just revert these changes and just turn the corresponding values in the team-monitor-website back to snake case.
| Ok(data) => { | ||
| let repo_provider = data["repository_provider"].to_string().trim_matches('"').to_string(); | ||
| let repo_name = data["event_payload"]["repository"]["name"].to_string().trim_matches('"').to_string(); | ||
| println!("data == {:?}", &data["eventPayload"]["repository"]); |
MuskanPaliwal
approved these changes
Sep 12, 2023
| async fn send_setup_info(setup_info: &Vec<SetupInfo>) { | ||
| let installation_id = env::var("INSTALL_ID") | ||
| .expect("INSTALL_ID must be set"); | ||
| println!("install_id = {:?}", &installation_id); |
Member
There was a problem hiding this comment.
Is it a part of debugging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the action items covered in the PR -