Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

await example close calls #473

Merged
merged 1 commit into from
Oct 26, 2023
Merged

await example close calls #473

merged 1 commit into from
Oct 26, 2023

Conversation

purplenicole730
Copy link
Member

@purplenicole730 purplenicole730 commented Oct 26, 2023 •
edited
Loading

Fix from this PR.
close() calls have to be awaited.

@purplenicole730 purplenicole730 marked this pull request as ready for review October 26, 2023 15:56
@purplenicole730 purplenicole730 requested a review from a team as a code owner October 26, 2023 15:56
cheukt
cheukt approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purplenicole730 purplenicole730 merged commit 961383b into viamrobotics:main Oct 26, 2023
9 checks passed
@purplenicole730 purplenicole730 deleted the await-example-close-calls branch October 26, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheukt cheukt cheukt approved these changes

@njooma njooma Awaiting requested review from njooma njooma is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purplenicole730 @cheukt