[APP-10017] Return invoice ID in create_invoice_and_charge_immediately

[edobranov]

Ticket

https://viam.atlassian.net/browse/APP-10017

Dependencies before merging

• API change: [APP-10017] Add invoice ID to CreateInvoiceAndChargeImmediatelyResponse api#776
• App change: https://github.com/viamrobotics/app/pull/10331
• Python SDK protos update: Automated Protos Update #1033

Manual testing

Ran this Python script against the temp environment in https://github.com/viamrobotics/app/pull/10331:

import asyncio

from viam.rpc.dial import DialOptions, Credentials
from viam.app.viam_client import ViamClient

async def main():
    viam_client = await connect()
    cloud = viam_client.billing_client

    invoice_id_response = await cloud.create_invoice_and_charge_immediately(
        "d8f70806-0a66-44a3-b229-813273e8b31b",
        1,
        "A short description.",
    )
    print(invoice_id_response)

    viam_client.close()

async def connect() -> ViamClient:
    dial_options = DialOptions.with_api_key(api_key="...", api_key_id="...")

    return await ViamClient.create_from_dial_options(
        dial_options,
        app_url="https://pr-10331-appmain-bplesliplq-uc.a.run.app",
    )

if __name__ == '__main__':
    asyncio.run(main())

And it printed the expected invoice ID:

$ python3 ./invoice-test.py

invoice_id: "ac73874b-a4fc-44d2-87a0-f0cd80bd52c9"

[stuqdog]

one minor question (feel free to leave as-is if that makes the most sense), otherwise lgtm!

[stuqdog]

(q) Would it make sense to return the inner ID so a user just gets the string and doesn't have to index into it?

[edobranov]

I'm hesitant since that makes it harder to return another value without a backwards breaking change. There was some talk in another channel about returning the invoice status too, so I think it's better if we leave the door open for something like that.