RSDK-9295 - refactor disable-web-browser name and behavior #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
@thegreatco fyi |
viambot
added
safe to test
purplenicole730
approved these changes
Dec 23, 2024
Comment on lines
-663
to
+664
| func (a *authFlow) loginAsUser(ctx context.Context) (*token, error) { | ||
| func (a *authFlow) loginAsUser(c *cli.Context) (*token, error) { | ||
| ctx := c.Context |
There was a problem hiding this comment.
For my own knowledge more than anything, why the change?
There was a problem hiding this comment.
Good question! The cli.Context has an io.Writer on it that allows us to write warning messages to terminal when connecting to the browser fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a slightly less verbose
no-browseralias to thedisable-web-browserflag, and changes default behavior such that a command won't fail when a browser can't be opened, but rather inform the user that the browser failed to open and that they can still visit the provided URL to log in.Tested manually.
Without flag, artificially injected error at browser open attempt:
With flag:
