Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-7005: Implement EnableAuthService in cli #4649

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

APP-7005: Implement EnableAuthService in cli #4649

wants to merge 3 commits into from
+83 −0

Conversation

gloriacai01
Copy link
Member

@gloriacai01 gloriacai01 requested a review from a team as a code owner December 19, 2024 22:41
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Dec 19, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 20, 2024
@gloriacai01 gloriacai01 requested a review from jr22 December 30, 2024 16:30
jr22
jr22 reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@jr22 jr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you manually test this and post example output? otherwise LGTM. also, am i correct that we havent merged the code in App that implements EnableAuthService? we should wait to merge this until thats merged

@maxhorowitz
Copy link
Member

@jr22 have not merged yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jr22 jr22 jr22 left review comments

@purplenicole730 purplenicole730 purplenicole730 approved these changes

@stuqdog stuqdog stuqdog approved these changes

@lia-viam lia-viam Awaiting requested review from lia-viam lia-viam is a code owner automatically assigned from viamrobotics/sdk-netcode

@maxhorowitz maxhorowitz Awaiting requested review from maxhorowitz

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gloriacai01 @maxhorowitz @jr22 @stuqdog @purplenicole730 @viambot