Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #383

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Update README.md #383

merged 5 commits into from
Jan 23, 2025

Conversation

JessamyT
Copy link
Contributor

We're making this consistent across the docs and marketing site

@JessamyT JessamyT requested a review from a team as a code owner January 16, 2025 23:34
mattjperez
mattjperez requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@mattjperez mattjperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few other embedded docs (ex. DEVELOPMENT.md, OTA.md, micro-rdk-installer/README.md) that seem to need small changes to be aligned with this.

If you think those changes aren't necessary, tag me again and I'll approve it.

@JessamyT JessamyT requested a review from mattjperez January 21, 2025 23:30
@JessamyT
Copy link
Contributor Author

Ah good point thanks Matt. I've changed a number of other instances.

acmorrow
acmorrow approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@acmorrow acmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM mod one sentence that needs some fixes.

examples/esp-idf-component/README.md Outdated Show resolved Hide resolved
mattjperez
mattjperez approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@mattjperez mattjperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

acmorrow
acmorrow approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@acmorrow acmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the improvements.

@JessamyT JessamyT merged commit 50cf7c3 into main Jan 23, 2025
11 checks passed
@JessamyT JessamyT deleted the JessamyT-patch-1 branch January 23, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjperez mattjperez mattjperez approved these changes

@acmorrow acmorrow acmorrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JessamyT @acmorrow @mattjperez