Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to validate non ascii urls (fixes #57) #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francisek
Copy link

Add function url_to_ascii that converts utf8 url to plain ascii one.

@vezaynk
Copy link
Owner

vezaynk commented Oct 7, 2017

This covers domains but not URL paths.

Half way there.

@vezaynk
Copy link
Owner

vezaynk commented Oct 8, 2017

I'm trying to test this but idn_to_ascii isn't on my system.. I have pretty standard install and the function is visible on the official docs without the need for any extensions. I have a fairly standard install too so this is strange.

This cannot be merged without a shim.

@francisek
Copy link
Author

idn_to_ascii is related to the intl extension. We could use pure php shim with an external library like https://github.com/phlylabs/idna-convert as the converstion rules are a bit complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants