Glebashnik/feed field generator #32842
Conversation
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,29 @@ | |||
| package ai.vespa.generative; | |||
There was a problem hiding this comment.
Same, I think we could put this in llm.generation
And maybe, since what separates it from Generator isn't that it's generating from a language model, but that it's taking an additional config specifying a prompt, we could call it something like PromptedGenerator, or ConfiguredGenerator?
linguistics/src/main/java/com/yahoo/language/process/Generator.java
Outdated
Show resolved
Hide resolved
linguistics/src/main/java/com/yahoo/language/process/Generator.java
Outdated
Show resolved
Hide resolved
| @@ -31,7 +34,7 @@ | |||
| * | |||
| * @author lesters | |||
| */ | |||
| public class LocalLLM extends AbstractComponent implements LanguageModel { | |||
| public class LocalLLM extends AbstractComponent implements LanguageModel, Generator { | |||
There was a problem hiding this comment.
The role of Generator is to apply a LanguageModel to a generation task specified by a context. This is a more general API so it's a bit messy for it to know about that context (and also to call itself through a utility defined elsewhere). I see the purpose though ... maybe there's a better solution, but I need to get some breakfast now.
…s in GenerateExpression
| * | ||
| * @author glebashnik | ||
| */ | ||
| public class LanguageModelTextGenerator extends AbstractComponent implements TextGenerator { |
There was a problem hiding this comment.
A bit verbose naming but quite precise.
I also considered LMTextGenerator.
| * | ||
| * @author glebashnik | ||
| */ | ||
| public interface TextGenerator { |
There was a problem hiding this comment.
Renamed from Generator to TextGenerator since Generator is too general.
| + outputType.getName()); | ||
|
|
||
| super.setOutputType(null, outputType, null, context); // TODO: Why not set actualOutput to outputType? | ||
| return outputType; // return input type the same as output type: string or array<string> |
There was a problem hiding this comment.
Input-output type inference is straightforward same type on input as on output.
string to array is handled outside using split expression (see testGeneratorWithStringInputArrayOutput test)
|
@bratseth Let me know if you think the design and naming are good enough. |
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.