Feature/lp 956 update php sdk #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alejouribesanchez
commented
Sep 25, 2024
alejouribesanchez
commented
- Added BankStatement process documents and GET endpoints
- Added AnyDocs process documents and GET endpoints
- Added W2 process documents and GET endpoints
- Added some unit tests
- Added missing PHP types for the functions
- Added support for PHP 8.3
- Update missing unit tests
- Update to version 1.0.4
Added BankStatement process documents and GET endpoints Added AnyDocs process documents and GET endpoints Added W2 process documents and GET endpoints Added some unit tests Added missing PHP types for the functions Added support for PHP 8.3
Update missing unit tests Update to version 1.0.4
manycoding
suggested changes
Sep 25, 2024
Add some links to the official documentation Add missing additional arguments to the GET endpoints
keep pathinfo() is more versatile as it can extract other file path components (like file extension) if needed. Remove file_get_contents() is simpler and reads the entire file at once. It’s easier to use, but can consume more memory for very large files since it loads everything into memory at once
Kaevan89
requested changes
Dec 10, 2024
Collaborator
Kaevan89
left a comment
Kaevan89
left a comment
There was a problem hiding this comment.
Fix GET methods with query parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.