Skip to content

with-docker: add new config file formats#90731

Merged
icyJoseph merged 4 commits intovercel:canaryfrom
karlhorky:patch-3
Mar 2, 2026
Merged

with-docker: add new config file formats#90731
icyJoseph merged 4 commits intovercel:canaryfrom
karlhorky:patch-3

Conversation

@karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Mar 1, 2026

What?

Update config files in the with-docker example inside the .dockerignore

Why?

They are outdated

How?

Add lines

cc @icyJoseph

Copilot AI review requested due to automatic review settings March 1, 2026 14:08
@nextjs-bot nextjs-bot added the examples Issue was opened via the examples template. label Mar 1, 2026
@nextjs-bot
Copy link
Collaborator

Allow CI Workflow Run

  • approve CI run for commit: 26fd126

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 1, 2026

Allow CI Workflow Run

  • approve CI run for commit: 8fbc120

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the examples/with-docker Docker build context exclusions so the example ignores additional modern config file naming formats and Compose file extensions, keeping production images leaner.

Changes:

  • Broadened test file ignores from explicit *.test.{ts,tsx,js,jsx} / *.spec.{...} to *.test.* and *.spec.*, and added common test-runner config globs (Vitest/Jest/Cypress/Playwright).
  • Expanded ignored Docker/Compose filenames to include compose.yml/.yaml and docker-compose*.yaml.
  • Added ignores for newer tool config formats (e.g. eslint.config.*, prettier.config.*, stylelint.config.*) and some AI agent metadata paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.anthropic/
.kiro
.claude
AGENTS.md
Copy link

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AGENTS.md is already excluded by the earlier *.md pattern, so this entry is redundant. Consider removing it (or, if the intent is to keep some markdown files in the build context, narrow the *.md rule and then keep explicit entries like this).

Suggested change
AGENTS.md

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, even if it is redundant now, it would be nice to keep for future changes, and to signal that this file should be ignored

Co-authored-by: Karl Horky <karl.horky@gmail.com>
@icyJoseph icyJoseph merged commit a0d293f into vercel:canary Mar 2, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants