Skip to content

Conversation

@wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Jan 9, 2026

Summary

Make parallel routes and interception route tests compatible with Cache Components (PPR) to re-enable them in the test manifest. Tests now work with both __NEXT_CACHE_COMPONENTS=true and without it.

Changes

  • Added generateStaticParams() to dynamic route pages
  • Replaced export const dynamic = 'force-dynamic' with await connection() from next/server for Cache Components compatibility
  • Wrapped parallel route slots in <Suspense> boundaries to support PPR streaming
  • Updated tests to use waitForElementByCss() for streamed elements instead of assuming immediate availability
  • Renamed layout-edge.tsx to layout.fixture-edge.tsx for clarity

Testing

All 6 targeted tests pass with both Cache Components enabled and disabled (backwards compatible).

Make parallel routes and interception route tests compatible with
Cache Components (PPR) by:

- Adding generateStaticParams() to dynamic route pages
- Using connection() instead of force-dynamic for dynamic behavior
- Wrapping parallel route slots in Suspense boundaries
- Using waitForElementByCss for streamed elements in tests
- Renaming layout-edge.tsx to layout.fixture-edge.tsx for clarity
@nextjs-bot nextjs-bot added created-by: Next.js team PRs by the Next.js team. tests labels Jan 9, 2026
@nextjs-bot
Copy link
Collaborator

Failing test suites

Commit: 6bfb466 | About building and testing Next.js

pnpm test-start test/e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts (job)

  • parallel-routes-and-interception (trailingSlash: false) > route intercepting > should render modal when paired with parallel routes (DD)
  • parallel-routes-and-interception (trailingSlash: true) > route intercepting > should render modal when paired with parallel routes (DD)
Expand output

● parallel-routes-and-interception (trailingSlash: true) › route intercepting › should render modal when paired with parallel routes

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  895 |       })
  896 |
> 897 |       it('should render modal when paired with parallel routes', async () => {
      |       ^
  898 |         const browser = await next.browser(
  899 |           `/intercepting-parallel-modal/vercel${trailingSlash ? '/' : ''}`
  900 |         )

  at it (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:897:7)
  at describe (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:722:5)
      at Array.forEach (<anonymous>)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:23:28)

● parallel-routes-and-interception (trailingSlash: false) › route intercepting › should render modal when paired with parallel routes

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  895 |       })
  896 |
> 897 |       it('should render modal when paired with parallel routes', async () => {
      |       ^
  898 |         const browser = await next.browser(
  899 |           `/intercepting-parallel-modal/vercel${trailingSlash ? '/' : ''}`
  900 |         )

  at it (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:897:7)
  at describe (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:722:5)
      at Array.forEach (<anonymous>)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:23:28)

@nextjs-bot
Copy link
Collaborator

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 457 MB 457 MB 🔴 +508 kB (+0%) █████
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ██▁█▁
Cold (First Request) 813ms 823ms ▁▇███
Warm (Listen) 456ms 456ms ▃▃▆▃▃
Warm (First Request) 339ms 343ms ▆▄▆█▄
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁██
Cold (First Request) 1.822s 1.824s ▅▄▅▅▄
Warm (Listen) 456ms 456ms ▁▅▅▅▅
Warm (First Request) 1.828s 1.832s ▄▄▅▄▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.106s 4.244s ▄▁▁▃▂
Cached Build 4.153s 4.206s ▇▂▁▄▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.942s 13.981s ▁▁▃▁▁
Cached Build 14.051s 14.021s ▁▁▃▁▁
node_modules Size 457 MB 457 MB 🔴 +508 kB (+0%) █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ⚠️ +74 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 793 B 785 B 🟢 8 B (-1%)
Total 793 B 785 B ✅ -8 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 449 B 451 B
Total 449 B 451 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.7 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 38.8 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.2 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.42 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ✅ -321 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B
_error-HASH.js gzip 182 B 182 B
css-HASH.js gzip 336 B 335 B
dynamic-HASH.js gzip 1.8 kB 1.8 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 352 B 349 B
hooks-HASH.js gzip 385 B 384 B
image-HASH.js gzip 580 B 580 B
index-HASH.js gzip 259 B 258 B
link-HASH.js gzip 2.5 kB 2.51 kB
routerDirect..HASH.js gzip 319 B 317 B
script-HASH.js gzip 385 B 387 B
withRouter-HASH.js gzip 316 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 124 kB
page.js gzip 239 kB 241 kB
Total 364 kB 365 kB ⚠️ +1.38 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 652 B 653 B
middleware-r..fest.js gzip 155 B 156 B
middleware.js gzip 32.9 kB 33 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.6 kB 34.6 kB ⚠️ +56 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B
Total 738 B 738 B
Build Cache
Canary PR Change
0.pack gzip 3.61 MB 3.63 MB 🔴 +21.6 kB (+1%)
index.pack gzip 99.5 kB 101 kB 🔴 +1.17 kB (+1%)
index.pack.old gzip 99.4 kB 98.3 kB 🟢 1.12 kB (-1%)
Total 3.81 MB 3.83 MB ⚠️ +21.7 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 303 kB 303 kB
app-page-exp..prod.js gzip 157 kB 158 kB
app-page-tur...dev.js gzip 302 kB 302 kB
app-page-tur..prod.js gzip 157 kB 158 kB
app-page-tur...dev.js gzip 299 kB 299 kB
app-page-tur..prod.js gzip 155 kB 156 kB
app-page.run...dev.js gzip 299 kB 299 kB
app-page.run..prod.js gzip 155 kB 156 kB
app-route-ex...dev.js gzip 68.2 kB 68.7 kB
app-route-ex..prod.js gzip 46.9 kB 47.5 kB 🔴 +616 B (+1%)
app-route-tu...dev.js gzip 68.2 kB 68.7 kB
app-route-tu..prod.js gzip 46.9 kB 47.6 kB 🔴 +616 B (+1%)
app-route-tu...dev.js gzip 67.8 kB 68.3 kB
app-route-tu..prod.js gzip 46.7 kB 47.3 kB 🔴 +618 B (+1%)
app-route.ru...dev.js gzip 67.8 kB 68.3 kB
app-route.ru..prod.js gzip 46.7 kB 47.3 kB 🔴 +617 B (+1%)
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 41.1 kB 41.1 kB
pages-api-tu..prod.js gzip 31.2 kB 31.2 kB
pages-api.ru...dev.js gzip 41.1 kB 41 kB
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB
pages-turbo....dev.js gzip 50.8 kB 50.8 kB
pages-turbo...prod.js gzip 38.2 kB 38.2 kB
pages.runtim...dev.js gzip 50.8 kB 50.7 kB
pages.runtim..prod.js gzip 38.2 kB 38.2 kB
server.runti..prod.js gzip 62 kB 62.2 kB
Total 2.67 MB 2.68 MB ⚠️ +6.1 kB
📝 Changed Files (25 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • pages-api-tu..ntime.dev.js
  • pages-api-tu..time.prod.js
  • pages-api.runtime.dev.js
  • pages-api.ru..time.prod.js
  • ... and 5 more
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js

Diff too large to display

app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

pages-api-tu..ntime.dev.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-api.runtime.dev.js

Diff too large to display

pages-api.ru..time.prod.js

Diff too large to display

pages-turbo...ntime.dev.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Next.js team PRs by the Next.js team. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants