-
Notifications
You must be signed in to change notification settings - Fork 30.3k
Experimental deferred entries handling #88347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
Failing test suitesCommit: 5dff961 | About building and testing Next.js
Expand output● deferred-entries webpack › should call onBeforeDeferredEntries before processing deferred entries during build |
| ([, entry]) => { | ||
| const entryData = entry as Entry | ChildEntry | ||
| if (entryData.type !== EntryTypes.ENTRY) return false | ||
|
|
||
| const isDeferred = isDeferredEntry( | ||
| (entryData as Entry).absolutePagePath | ||
| .replace(appDir || '', '') | ||
| .replace(pagesDir || '', '') | ||
| .replace(rootDir, ''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug is confirmed by the failing test. The test shows that deferred entries are being processed before the callback is called, which indicates that the fragile path extraction is incorrectly identifying which entries are deferred. The fix extracts the page path directly from the entryKey instead of trying to parse it from the file system path, which should resolve both this test failure and the underlying logic bug.
| private onBeforeDeferredEntries?: () => Promise<void> | ||
| private deferredEntrypoints?: webpack.EntryObject | ||
| private callbackCalled: boolean = false | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug prevents the onBeforeDeferredEntries callback from being called on subsequent HMR cycles in development mode. The fix resets the callbackCalled flag when a new compilation starts by hooking into compiler.hooks.invalid, ensuring consistent behavior across all HMR cycles.
Stats from current PR🔴 1 regression
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **430 kB** → **431 kB**
|
| Canary | PR | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 793 B | 787 B | ✓ |
| Total | 793 B | 787 B | ✅ -6 B |
Build Details
Build Manifests
| Canary | PR | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 449 B | 450 B | ✓ |
| Total | 449 B | 450 B |
📦 Webpack
Client
Main Bundles
| Canary | PR | Change | |
|---|---|---|---|
| 2086.HASH.js gzip | 169 B | N/A | - |
| 2161-HASH.js gzip | 5.41 kB | N/A | - |
| 2747-HASH.js gzip | 4.48 kB | N/A | - |
| 4322-HASH.js gzip | 52.7 kB | N/A | - |
| ec793fe8-HASH.js gzip | 62.3 kB | N/A | - |
| framework-HASH.js gzip | 59.8 kB | 59.8 kB | ✓ |
| main-app-HASH.js gzip | 252 B | 254 B | ✓ |
| main-HASH.js gzip | 38.6 kB | 38.9 kB | ✓ |
| webpack-HASH.js gzip | 1.68 kB | 1.68 kB | ✓ |
| 1596.HASH.js gzip | N/A | 169 B | - |
| 2658-HASH.js gzip | N/A | 52.5 kB | - |
| 6349-HASH.js gzip | N/A | 4.46 kB | - |
| 7019-HASH.js gzip | N/A | 5.42 kB | - |
| b17a3386-HASH.js gzip | N/A | 62.3 kB | - |
| Total | 225 kB | 225 kB |
Polyfills
| Canary | PR | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Total | 39.4 kB | 39.4 kB | ✓ |
Pages
| Canary | PR | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 194 B | 193 B | ✓ |
| _error-HASH.js gzip | 182 B | 182 B | ✓ |
| css-HASH.js gzip | 336 B | 335 B | ✓ |
| dynamic-HASH.js gzip | 1.8 kB | 1.8 kB | ✓ |
| edge-ssr-HASH.js gzip | 256 B | 256 B | ✓ |
| head-HASH.js gzip | 352 B | 349 B | ✓ |
| hooks-HASH.js gzip | 385 B | 384 B | ✓ |
| image-HASH.js gzip | 580 B | 580 B | ✓ |
| index-HASH.js gzip | 259 B | 258 B | ✓ |
| link-HASH.js gzip | 2.5 kB | 2.51 kB | ✓ |
| routerDirect..HASH.js gzip | 319 B | 317 B | ✓ |
| script-HASH.js gzip | 385 B | 387 B | ✓ |
| withRouter-HASH.js gzip | 316 B | 315 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Total | 7.97 kB | 7.96 kB | ✅ -8 B |
Server
Edge SSR
| Canary | PR | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 125 kB | 125 kB | ✓ |
| page.js gzip | 239 kB | 241 kB | 🔴 +2.48 kB (+1%) |
| Total | 364 kB | 366 kB |
Middleware
| Canary | PR | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 653 B | 652 B | ✓ |
| middleware-r..fest.js gzip | 155 B | 156 B | ✓ |
| middleware.js gzip | 32.7 kB | 33.2 kB | 🔴 +521 B (+2%) |
| edge-runtime..pack.js gzip | 842 B | 842 B | ✓ |
| Total | 34.3 kB | 34.9 kB |
Build Details
Build Manifests
| Canary | PR | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 738 B | 738 B | ✓ |
| Total | 738 B | 738 B | ✓ |
Build Cache
| Canary | PR | Change | |
|---|---|---|---|
| 0.pack gzip | 3.6 MB | 3.64 MB | 🔴 +36.1 kB (+1%) |
| index.pack gzip | 98.4 kB | 99.7 kB | 🔴 +1.33 kB (+1%) |
| index.pack.old gzip | 98.2 kB | 99.6 kB | 🔴 +1.42 kB (+1%) |
| Total | 3.8 MB | 3.84 MB |
🔄 Shared (bundler-independent)
Runtimes
| Canary | PR | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 303 kB | 303 kB | ✓ |
| app-page-exp..prod.js gzip | 157 kB | 158 kB | ✓ |
| app-page-tur...dev.js gzip | 302 kB | 303 kB | ✓ |
| app-page-tur..prod.js gzip | 157 kB | 158 kB | ✓ |
| app-page-tur...dev.js gzip | 299 kB | 300 kB | ✓ |
| app-page-tur..prod.js gzip | 155 kB | 156 kB | ✓ |
| app-page.run...dev.js gzip | 299 kB | 300 kB | ✓ |
| app-page.run..prod.js gzip | 155 kB | 156 kB | ✓ |
| app-route-ex...dev.js gzip | 68.2 kB | 68.7 kB | ✓ |
| app-route-ex..prod.js gzip | 46.9 kB | 47.5 kB | 🔴 +629 B (+1%) |
| app-route-tu...dev.js gzip | 68.2 kB | 68.8 kB | ✓ |
| app-route-tu..prod.js gzip | 46.9 kB | 47.6 kB | 🔴 +630 B (+1%) |
| app-route-tu...dev.js gzip | 67.8 kB | 68.4 kB | ✓ |
| app-route-tu..prod.js gzip | 46.7 kB | 47.3 kB | 🔴 +632 B (+1%) |
| app-route.ru...dev.js gzip | 67.8 kB | 68.3 kB | ✓ |
| app-route.ru..prod.js gzip | 46.7 kB | 47.3 kB | 🔴 +631 B (+1%) |
| dist_client_...dev.js gzip | 324 B | 324 B | ✓ |
| dist_client_...dev.js gzip | 326 B | 326 B | ✓ |
| dist_client_...dev.js gzip | 318 B | 318 B | ✓ |
| dist_client_...dev.js gzip | 317 B | 317 B | ✓ |
| pages-api-tu...dev.js gzip | 41.1 kB | 41.1 kB | ✓ |
| pages-api-tu..prod.js gzip | 31.2 kB | 31.2 kB | ✓ |
| pages-api.ru...dev.js gzip | 41.1 kB | 41.1 kB | ✓ |
| pages-api.ru..prod.js gzip | 31.2 kB | 31.2 kB | ✓ |
| pages-turbo....dev.js gzip | 50.8 kB | 50.8 kB | ✓ |
| pages-turbo...prod.js gzip | 38.2 kB | 38.2 kB | ✓ |
| pages.runtim...dev.js gzip | 50.8 kB | 50.8 kB | ✓ |
| pages.runtim..prod.js gzip | 38.2 kB | 38.2 kB | ✓ |
| server.runti..prod.js gzip | 62 kB | 62.2 kB | ✓ |
| Total | 2.67 MB | 2.68 MB |
📝 Changed Files (21 files)
Files with changes:
app-page-exp..ntime.dev.jsapp-page-exp..time.prod.jsapp-page-tur..ntime.dev.jsapp-page-tur..time.prod.jsapp-page-tur..ntime.dev.jsapp-page-tur..time.prod.jsapp-page.runtime.dev.jsapp-page.runtime.prod.jsapp-route-ex..ntime.dev.jsapp-route-ex..time.prod.jsapp-route-tu..ntime.dev.jsapp-route-tu..time.prod.jsapp-route-tu..ntime.dev.jsapp-route-tu..time.prod.jsapp-route.runtime.dev.jsapp-route.ru..time.prod.jspages-turbo...ntime.dev.jspages-turbo...time.prod.jspages.runtime.dev.jspages.runtime.prod.js- ... and 1 more
View diffs
app-page-exp..ntime.dev.js
failed to diffapp-page-exp..time.prod.js
Diff too large to display
app-page-tur..ntime.dev.js
failed to diffapp-page-tur..time.prod.js
Diff too large to display
app-page-tur..ntime.dev.js
failed to diffapp-page-tur..time.prod.js
Diff too large to display
app-page.runtime.dev.js
failed to diffapp-page.runtime.prod.js
Diff too large to display
app-route-ex..ntime.dev.js
Diff too large to display
app-route-ex..time.prod.js
Diff too large to display
app-route-tu..ntime.dev.js
Diff too large to display
app-route-tu..time.prod.js
Diff too large to display
app-route-tu..ntime.dev.js
Diff too large to display
app-route-tu..time.prod.js
Diff too large to display
app-route.runtime.dev.js
Diff too large to display
app-route.ru..time.prod.js
Diff too large to display
pages-turbo...ntime.dev.js
Diff too large to display
pages-turbo...time.prod.js
Diff too large to display
pages.runtime.dev.js
Diff too large to display
pages.runtime.prod.js
Diff too large to display
server.runtime.prod.js
Diff too large to display
e958a74 to
5dff961
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
This is just an exploration into a deferred entries hook in
next.config