Skip to content

read task cell should only need Data #88339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sokra wants to merge 1 commit into
base: sokra/task-prio
Choose a base branch
from
+5 −3
Draft

read task cell should only need Data #88339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,10 +873,10 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
// Having a task_pair here is not optimal, but otherwise this would lead to a race
// condition. See below.
// TODO(sokra): solve that in a more performant way.
let (task, reader) = ctx.task_pair(task_id, reader_id, TaskDataCategory::All);
let (task, reader) = ctx.task_pair(task_id, reader_id, TaskDataCategory::Data);
(task, Some(reader))
} else {
(ctx.task(task_id, TaskDataCategory::All), None)
(ctx.task(task_id, TaskDataCategory::Data), None)
Comment on lines +876 to +879
Copy link
Contributor

@vercel vercel bot Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task is incorrectly re-scheduled when InProgress state is not loaded due to loading with Data instead of All category

Fix on Vercel

};

let content = if final_read_hint {
Expand Down Expand Up @@ -979,7 +979,9 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
TaskExecutionReason::CellNotAvailable,
|| self.get_task_desc_fn(task_id),
));
ctx.schedule_task(task, TaskPriority::Initial);
drop(task);

ctx.schedule(task_id, TaskPriority::Initial);

Ok(Err(listener))
}
Expand Down
Loading