Fix console.trace including unexpected lines #88319
Draft
+154
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextjs-bot
added
created-by: Turbopack team
Collaborator
Failing test suitesCommit: 4e97364 | About building and testing Next.js
Expand output● interception-dynamic-segment › should work when interception route is paired with a dynamic segment ● interception-dynamic-segment › should intercept consistently with back/forward navigation ● interception-dynamic-segment › should intercept multiple times from root |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| if (methodName === 'trace' && traceStack !== undefined) { | ||
| const label = args.length > 0 ? `Trace: ${args.join(' ')}` : 'Trace' | ||
| const traceOutput = `${label}\n${traceStack}` | ||
| // Use console.log with the dimmed trace output |
Contributor
There was a problem hiding this comment.
Double dimming of console.trace output when dim=true: trace output is converted to dimmed ANSI codes, then passed to the patched console.log which applies the dimming conversion again, resulting in malformed output
| // For console.trace, output the label + clean stack using console.log | ||
| // This goes through the wrapper chain for proper file logging | ||
| const label = args.length > 0 ? `Trace: ${args.join(' ')}` : 'Trace' | ||
| return console.log(`${label}\n${traceStack}`) as ReturnType<F> |
Contributor
There was a problem hiding this comment.
Console.trace output loses async storage context when calling console.log(), breaking proper file logging and dimming behavior
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **430 kB** → **430 kB** ✅ -4 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixed
console.traceto output a clean stack trace that shows the actual call site and parent frames, instead of polluting the output with internal Next.js console patching frames.Why?
Before this fix, calling
console.trace('Test')in a Next.js project would output:The internal wrapper frames from
console-file,console-exit, andconsole-dim.externalwere polluting the stack trace, making it difficult to debug.How?
In
console-dim.external.tsx(the outermost wrapper):getCleanStackTrace()function that captures the stack trace early and filters out any frames containing/node-environment-extensions/console.tracebefore entering the wrapper chainconsole.log(which still goes through the wrapper chain for proper file logging) instead of delegating to the originalconsole.traceAfter this fix:
Test Plan
Added unit test
should output console.trace with a clean stack trace without internal wrapper framestoconsole-dim.external.test.tsthat verifies:/node-environment-extensions/frames