Skip to content

Turbopack: include children count in "task execution completed" span #87318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sokra merged 1 commit into from
Jan 8, 2026
+7 −1
Merged

Turbopack: include children count in "task execution completed" span #87318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,7 +1773,11 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
// at the start of every step.

#[cfg(not(feature = "trace_task_details"))]
let _span = tracing::trace_span!("task execution completed").entered();
let span = tracing::trace_span!(
"task execution completed",
new_children = tracing::field::Empty
)
.entered();
#[cfg(feature = "trace_task_details")]
let span = tracing::trace_span!(
"task execution completed",
Expand All @@ -1782,6 +1786,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
Ok(value) => display(either::Either::Left(value)),
Err(err) => display(either::Either::Right(err)),
},
new_children = tracing::field::Empty,
immutable = tracing::field::Empty,
new_output = tracing::field::Empty,
output_dependents = tracing::field::Empty,
Expand Down Expand Up @@ -1832,6 +1837,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
}

let has_new_children = !new_children.is_empty();
span.record("new_children", new_children.len());

if has_new_children {
self.task_execution_completed_unfinished_children_dirty(&mut ctx, &new_children)
Expand Down
Loading