Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metadata] Change the array head to single node in flight data #74299

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Dec 25, 2024

What

Now we can change the HeadData back to ReactNode as the metadata is separated from it, and rendered in the body along with page component. The array type of HeadData was a temporary state where we renders head as array to separate the viewport and metadata. Now since they're fully separated we can keep the Head simple with viewport data only.

This PR is stacked on #74262.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 25, 2024
Copy link
Member Author

huozhi commented Dec 25, 2024

@huozhi huozhi changed the title change the array head back to node [metadata] Change the array head to single node in flight data Dec 25, 2024
@ijjk
Copy link
Member

ijjk commented Dec 25, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 25, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
buildDuration 22.7s 20.8s N/A
buildDurationCached 20s 17.7s N/A
nodeModulesSize 417 MB 417 MB N/A
nextStartRea..uration (ms) 533ms 530ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
1187-HASH.js gzip 52.6 kB 52.5 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
index.html gzip 524 B 522 B N/A
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
middleware-b..fest.js gzip 672 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 363 kB 363 kB N/A
app-page-exp..prod.js gzip 129 kB 129 kB N/A
app-page-tur..prod.js gzip 142 kB 142 kB N/A
app-page-tur..prod.js gzip 138 kB 138 kB N/A
app-page.run...dev.js gzip 352 kB 352 kB N/A
app-page.run..prod.js gzip 125 kB 125 kB N/A
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 1.2 MB 1.2 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-25-replace_array_head_to_react_node Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +124 B
index.pack gzip 74.6 kB 74.1 kB N/A
Overall change 2.08 MB 2.08 MB ⚠️ +124 B
Diff details
Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 1e9ca24

@huozhi huozhi force-pushed the huozhi/12-23-_move_metadata_render branch from ed35f62 to 9be477c Compare January 6, 2025 10:52
@huozhi huozhi force-pushed the 12-25-replace_array_head_to_react_node branch from e87e0b7 to 814d75d Compare January 6, 2025 10:56
@huozhi huozhi marked this pull request as ready for review January 6, 2025 11:49
@huozhi huozhi requested a review from ztanner January 6, 2025 11:49
Base automatically changed from huozhi/12-23-_move_metadata_render to canary January 6, 2025 20:30
@huozhi huozhi force-pushed the 12-25-replace_array_head_to_react_node branch from 814d75d to 1e9ca24 Compare January 7, 2025 13:05
@huozhi huozhi merged commit eb6ea06 into canary Jan 7, 2025
130 checks passed
@huozhi huozhi deleted the 12-25-replace_array_head_to_react_node branch January 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants