Skip to content

use LegendList reportContentInset#42

Open
jmeistrich wants to merge 1 commit intomainfrom
f/ll-reportContentInset
Open

use LegendList reportContentInset#42
jmeistrich wants to merge 1 commit intomainfrom
f/ll-reportContentInset

Conversation

@jmeistrich
Copy link
Collaborator

  • update LegendList to 3.0.0-beta.22 which has a reportContentInset function
  • remove the workarounds setting contentInset in JS, and just reportContentInset when it changes from native

@vercel
Copy link
Contributor

vercel bot commented Jan 24, 2026

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: aix.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The legendListRef is never passed to the LegendList component, causing reportContentInset to never be called.

Fix on Vercel

@jmeistrich jmeistrich force-pushed the f/ll-reportContentInset branch from 83b55ca to bfe333b Compare January 25, 2026 02:31
@jmeistrich jmeistrich force-pushed the f/ll-reportContentInset branch from f7f8448 to de58bda Compare February 17, 2026 05:10
@nandorojo
Copy link
Collaborator

@jmeistrich mind retroactively signing all the commits here?

Instructions:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin f/ll-reportContentInset

…nsets from JS to just update its internal state, so we can adjust them natively

Signed-off-by: Jay Meistrich <jmeistrich@gmail.com>
@jmeistrich jmeistrich force-pushed the f/ll-reportContentInset branch from de58bda to 7dd98f9 Compare February 18, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments