-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(dashboard): Fix localization issues in Insights Dashboard #4189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe PR updates dashboard components to support internationalization using Lingui. Changes include: adding documentation for i18n extraction and application commands, introducing a Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Description
Fixes #4004
resolves OSS-24
Big diff due to added translations
Fixes localization issues in the Insights Dashboard where German (and other non-English) users saw English date formats, untranslated strings, and incorrect tooltip labels.
Changes:
<Trans>("0 of 10 rows selected")useLocalFormat().formatRelativeDate()instead ofdate-fns.formatRelative()for locale-aware relative dates(same pattern, discovered while fixing):
date-fns→useLocalFormatfix<Trans>Screenshots
Checklist
📌 Always:
👍 Most of the time: