👨‍🔬 Add test cases covering #93

Thanks to @zeearth
veliovgroup · Jun 17, 2022 · 67c7661 · 67c7661
1 parent 887e833
commit 67c7661
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/test/client/router.core.spec.js b/test/client/router.core.spec.js
@@ -1,5 +1,4 @@
 import { _ }          from 'meteor/underscore';
-import { check }      from 'meteor/check';
 import { GetSub }     from './_helpers.js';
 import { Meteor }     from 'meteor/meteor';
 import { Random }     from 'meteor/random';
@@ -176,9 +175,9 @@ Tinytest.addAsync('Client - Router - define and go to route with UTF-8 fields',
 });
 
 Tinytest.addAsync('Client - Router - parse params and query', (test, next) => {
-  const rand   = Random.id();
+  const rand = Random.id();
   let rendered = 0;
-  let params   = {}
+  let params = {};
 
   FlowRouter.route('/' + rand + '/:foo', {
     action(_params) {

diff --git a/test/common/router.path.spec.js b/test/common/router.path.spec.js
@@ -93,6 +93,30 @@ Tinytest.add('Common - Router - path - optional last param missing', function (t
   test.equal(path, expectedPath);
 });
 
+Tinytest.add('Common - Router - path - both optional last param missing', function (test) {
+  var pathDef = "/blog/:id?/:action?";
+  var fields = {
+    id: "6135cb32d14df059605901fd",
+    action: ''
+  };
+  var expectedPath = "/blog/6135cb32d14df059605901fd";
+
+  var path = FlowRouter.path(pathDef, fields);
+  test.equal(path, expectedPath);
+});
+
+Tinytest.add('Common - Router - path - both optional last param exists', function (test) {
+  var pathDef = "/blog/:id?/:action?";
+  var fields = {
+    id: "6135cb32d14df059605901fd",
+    action: 'view'
+  };
+  var expectedPath = "/blog/6135cb32d14df059605901fd/view";
+
+  var path = FlowRouter.path(pathDef, fields);
+  test.equal(path, expectedPath);
+});
+
 Tinytest.add('Common - Router - path - optional last param exists', function (test) {
   var pathDef = "/blog/:blogId/some/:name?";
   var fields = {