Added swipe down to refresh#89
Conversation
|
Why did the check fail? It complies on my system. |
|
Looks like the CI system doesn't have the needed Android SDK version. FAILURE: Build failed with an exception.
A problem occurred configuring project ':app'.
|
velazcod
left a comment
velazcod
left a comment
There was a problem hiding this comment.
Thanks for the PR, and my sincerest apologies for abandoning this project for so long. Will try to catch up.
|
|
||
| //Checks if the swipe refresh indicator is active. Turns off if it is | ||
| if(mSwipeRefreshLayout.isRefreshing()) | ||
| mSwipeRefreshLayout.setRefreshing(false); |
There was a problem hiding this comment.
I'd prefer if this was fully wrapped with curly brackets.
There was a problem hiding this comment.
I'm a bit of a newbie. I don't exactly understand by what you mean by wrapping with curly braces. Mind explaining?
There was a problem hiding this comment.
Never mind. Got what you mean. I'll get it done...
|
@velazcod Is it fine now? |
|
This is one awesome feature, we need it. |
| <color name="blue_primary_dark">#ff293c68</color> | ||
| <color name="blue_accent">#738ffe</color> | ||
|
|
||
| <color name="swipe_color_1">#33B5E5</color> |
There was a problem hiding this comment.
Why the google colors? Wouldn't be using something like blue_accent with blue_primary better looking?
4 participants
Page refreshes when swiping down from top, like Chrome