Skip to content

Commit

Permalink
undo: back out the color condition check as it still makes the cartes…
Browse files Browse the repository at this point in the history
…ian plot draw unexpectedly
  • Loading branch information
hydrosquall committed Jan 20, 2025
1 parent 3b1d979 commit c3b3b99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export function stack(m: Mark | MarkDef, encoding: Encoding<string>): StackPrope
// TBD: we should only enter this branch if there's also a "color" and maybe a group channel?
const isPolar = isPolarPositionChannel(fieldChannel) || isPolarPositionChannel(dimensionChannel);

if (!hasSameDimensionAndStackedField && (isPolar ? dimensionChannel === fieldChannel || encoding['color'] : true)) {
if (!hasSameDimensionAndStackedField && (isPolar ? dimensionChannel === fieldChannel : true)) {
// avoid grouping by the stacked field
// TKTK: find out why
groupbyChannels.push(dimensionChannel);
Expand Down

0 comments on commit c3b3b99

Please sign in to comment.